Skip to content

Conversation

@damacus
Copy link
Owner

@damacus damacus commented Jan 6, 2026

  • docs: add progress tracking for Protocol 3.5 implementation
  • Cascade snapshot 2026-01-06T14:17:58.102289Z
  • docs: Update instructions

Copilot AI review requested due to automatic review settings January 6, 2026 16:02
@damacus damacus enabled auto-merge (squash) January 6, 2026 16:02
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.47%. Comparing base (e3eca23) to head (a5f7ee2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   71.47%   71.47%           
=======================================
  Files          55       55           
  Lines        1774     1774           
=======================================
  Hits         1268     1268           
  Misses        506      506           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures the documentation by creating dedicated pages for supported models and instructions for adding new vacuum models. It also adds progress tracking for Protocol 3.5 implementation work.

Key changes:

  • Creates a comprehensive supported models page with protocol versions and model series groupings
  • Moves model listings from configuration.md to a dedicated supported-models.md page
  • Adds detailed instructions for contributing new vacuum model support

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
site_docs/supported-models.md New comprehensive listing of 40+ supported Eufy RoboVac models with protocol versions and series groupings
site_docs/adding-new-vacuum.md New contributor guide with step-by-step instructions for adding new vacuum model support
site_docs/index.md Updates navigation to include links to new documentation pages
site_docs/configuration.md Removes redundant model listing and replaces with link to dedicated page
progress.txt Adds tracking document for Protocol 3.5 implementation progress
commit_msg.txt Adds commit message for the documentation update

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

| Model Code | Friendly Name | Protocol |
|------------|----------------------|----------|
| T1250 | RoboVac G40 | 3.3 |
| T2080 | RoboVac S1 Pro | 3.4 |
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an inconsistency between the new supported-models.md file and the configuration.md file that was removed. In the old configuration.md, T2080 was documented as "RoboVac G40 Hybrid", but in the new supported-models.md file on line 10, it's listed as "RoboVac S1 Pro". Please verify which is the correct model name for T2080 and ensure consistency across documentation.

Suggested change
| T2080 | RoboVac S1 Pro | 3.4 |
| T2080 | RoboVac G40 Hybrid | 3.4 |

Copilot uses AI. Check for mistakes.
- **G30**: T2190, T2250, T2251, T2252, T2253, T2273
- **G32**: T2270
- **G35**: T2255
- **G40**: T1250, T2259, T2277, T2278, T2280
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2277 is listed as "eufy Clean L60 SES" in the Model Compatibility Table (line 42), but it's also included in the G40 series grouping (line 58). This creates confusion about whether T2277 belongs to the G40 series or the L60 series. Based on the model name "L60 SES", it should only be in the L60 series grouping. Please remove T2277 from the G40 series list on line 58.

Suggested change
- **G40**: T1250, T2259, T2277, T2278, T2280
- **G40**: T1250, T2259, T2278, T2280

Copilot uses AI. Check for mistakes.
| T2273 | RoboVac G30 | 3.3 |
| T2275 | RoboVac L35 Hybrid | 3.4 |
| T2276 | RoboVac L35 Hybrid+ | 3.4 |
| T2277 | eufy Clean L60 SES | 3.4 |
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an inconsistency between the old configuration.md documentation and the new supported-models.md. T2277 was previously documented as "RoboVac G40 Hybrid" but is now listed as "eufy Clean L60 SES". Please verify which is the correct model name for T2277 and ensure consistency across documentation.

Copilot uses AI. Check for mistakes.
@damacus damacus closed this Jan 6, 2026
auto-merge was automatically disabled January 6, 2026 17:03

Pull request was closed

@damacus damacus deleted the cascade/ad-documentation-under-site-docs-to-28a948 branch January 6, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant