Rename spatial_dimension to input_dimension across codebase
#350
Assignees
Labels
core
Core functionality of the package
refactoring
Changes in the implementation with no or minor changes in behaviours
Milestone
Comments
damar-wicaksono
added
refactoring
damar-wicaksono
added a commit
that referenced
this issue
Nov 4, 2024
The property `spatial_dimension` that appears in `ProbInput` and `UQTestFunBareABC` has been renamed to `input_dimension` for clarity (as opposed to `output_dimension`). Furthermore: - The test suite has been accordingly updated. - All occurences in the docs have been replaced accordingly. - The issue with the opening paragraphs of the Sobol'-G function has been resolved (Issue #366). This commit should resolve Issues #350 and #366.
|
This issue has been resolved by PR #367. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following Issue #345, if the new abstract property is introduced, then it would be more intuitive to also rename the property
spatial_dimension1 toinput_dimension.Footnotes
the main reason to adopt the name
spatial_dimensionin the first place (albeit rather unconventional to the community) was due to my involvement in maintaining the minterpy package. There the dimensionality of the polynomials is calledspatial_dimension. ↩The text was updated successfully, but these errors were encountered: