Rename spatial_dimension to input_dimension
#367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property `spatial_dimension` that appears in `ProbInput` and `UQTestFunBareABC` has been renamed to `input_dimension` for clarity (as opposed to `output_dimension`). Furthermore: - The test suite has been accordingly updated. - All occurences in the docs have been replaced accordingly. - The issue with the opening paragraphs of the Sobol'-G function has been resolved (Issue #366). This commit should resolve Issues #350 and #366.
damar-wicaksono
added
bug
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property
spatial_dimensionthat appears inProbInputandUQTestFunBareABChas been renamed toinput_dimensionfor clarity (as opposed tooutput_dimension).Furthermore:
This PR should resolve Issues #350 and #366.