Adding validation for nfspvc(webhook and CRD validation) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeevi
reviewed
Dec 19, 2023
api/v1alpha1/nfspvc_webhook.go
Outdated
Comment on lines
60
to
62
| // TODO(user): EDIT THIS FILE! THIS IS SCAFFOLDING FOR YOU TO OWN! | ||
|
|
||
| // TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation. |
mzeevi
requested changes
Dec 19, 2023
api/v1alpha1/nfspvc_webhook.go
Outdated
| func (r *NfsPvc) ValidateCreate() (admission.Warnings, error) { | ||
| nfspvclog.Info("validate create", "name", r.Name) | ||
|
|
||
| // TODO(user): fill in your validation logic upon object creation. |
api/v1alpha1/nfspvc_webhook.go
Outdated
| func (r *NfsPvc) ValidateUpdate(old runtime.Object) (admission.Warnings, error) { | ||
| nfspvclog.Info("validate update", "name", r.Name) | ||
|
|
||
| // TODO(user): fill in your validation logic upon object update. |
api/v1alpha1/nfspvc_webhook.go
Outdated
Comment on lines
103
to
117
| func (r *NfsPvc) isRestrictedFieldUpdated(old *NfsPvc) (bool, string) { | ||
| // modifying these fields is forbidden. | ||
| if !reflect.DeepEqual(r.Spec.Server, old.Spec.Server) { | ||
| return true, "server" | ||
| } | ||
| if !reflect.DeepEqual(r.Spec.Path, old.Spec.Path) { | ||
| return true, "path" | ||
| } | ||
| if !reflect.DeepEqual(r.Spec.AccessModes, old.Spec.AccessModes) { | ||
| return true, "access modes" | ||
| } | ||
| if !reflect.DeepEqual(r.Spec.Capacity, old.Spec.Capacity) { | ||
| return true, "capacity" | ||
| } | ||
| return false, "" |
There was a problem hiding this comment.
String is returned but not used
api/v1alpha1/nfspvc_webhook.go
Outdated
| corev1.ReadWriteOnce, | ||
| corev1.ReadOnlyMany, | ||
| corev1.ReadWriteMany, | ||
| corev1.ReadWriteOncePod) |
There was a problem hiding this comment.
Think the end parenthesis needs to be in a newline? How does go fmt handle it?
omer5yerushalmi
force-pushed
the
nfspvc-validation
branch
from
006776a
to
624e1a7
Compare
|
The CI here is failing, I think you need to pull from main following #14, rebase and commit |
omer5yerushalmi
force-pushed
the
nfspvc-validation
branch
from
624e1a7
to
126311a
Compare
Signed-off-by: omer5yerushalmi <omery2700@gmail.com>
omer5yerushalmi
force-pushed
the
nfspvc-validation
branch
from
126311a
to
869e05f
Compare
|
/lgtm |
mzeevi
approved these changes
Dec 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzeevi, omer5yerushalmi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.