Support zed:// hyperlinks with a new colon-omitting {:line} placeholder #2060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support for the {:line} placeholder which expands to ":N"
when a line number exists, or empty string otherwise. this prevents
trailing colons from being added to file paths when hyperlinks
don't have line numbers.
fixes dandavison#1965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a new hyperlink placeholder:
{:line}similar to
{line}but includes a colon prefix when a line is provided, otherwise prints nothing. intended as a fix for #1965 – a problem i ran into with zed.i'm open to other solutions, such as defaulting line to 1, like what ripgrep does1 – but i feel like it's undesirable to take the user back to line 1 if they have the file open and a cursor on a different line. happy to go with line 1 though if that's preferred (that change now up at #2061)
Footnotes
https://manpages.debian.org/testing/ripgrep/rg.1.en.html#:~:text=number%20was%20given)%2C-,then%20it%20is%20automatically%20replaced%20with%20the%20value%201.,-%7Bcolumn%7D ↩