-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH action to generate report #199
Draft
asmacdo
wants to merge
39
commits into
main
Choose a base branch
from
cron-data-usage-report
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+263
−0
Draft
Changes from 10 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
d16abb2
Inital commit to add GH action to generate report
asmacdo 713d64c
Assume Jupyterhub Provisioning Role
asmacdo 519360c
Fixup: indent
asmacdo e6f4814
Rename job
asmacdo 72496f4
Add assumed role to update-kubeconfig
asmacdo 8428d3a
No need to add ProvisioningRole to masters
asmacdo e170b59
Deploy a pod to the cluster, and schedule with Karpenter
asmacdo bfce046
Fixup: correct path to pod manifest
asmacdo 0993129
Fixup again ugh, rename file
asmacdo 87027d2
Delete Pod even if previous step times out
asmacdo 686f686
Hack out initial du
asmacdo ff52971
tmp comment out job deployment, test dockerhub build
asmacdo ca6db89
Fixup hyphens for image name
asmacdo d228f9d
Write file to output location
asmacdo 68f707f
use kubectl cp to retrieve report
asmacdo ad6b589
Combine run blocks to use vars
asmacdo f18e8b7
Mount efs and pass arg to du script
asmacdo 387cfc1
Comment out repo pushing, lets see if the report runs
asmacdo 04b4193
Restrict job to asmacdo for testing
asmacdo a443081
Sanity check. Just list the directories
asmacdo 99ac264
Job was deployed, but never assigned to node, back to sanity check
asmacdo 6ee89b2
change from job to pod
asmacdo a8f6ed3
deploy pod to same namespace as pvc
asmacdo 664853b
Use ns in action
asmacdo e35c974
increase timeout to 60s
asmacdo a8af5f2
fixup: image name in manifest
asmacdo 024cf6e
increase timeout to 150
asmacdo 49c346e
override entrypoint so i can debug with exec
asmacdo 0191c85
bound /home actually meant path was /home/home/asmacdo
asmacdo 3eb9157
Create output dir prior to writing report
asmacdo 676a00e
pod back to job
asmacdo c085751
Fixup use the correct job api
asmacdo 3e18a37
Add namespace to pod retrieval
asmacdo 0fa5ece
write directly to pv to test job
asmacdo e1ecbc3
fixup script fstring
asmacdo 082d3cc
no retry on failure, we were spinning up 5 pods, lets just fail 1 time
asmacdo d46ea44
Fixup backup limit job not template
asmacdo 965a81e
Initial report
asmacdo 7366d2d
disable report
asmacdo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# manifests/hello-world-pod.yaml | ||
apiVersion: v1 | ||
kind: Pod | ||
metadata: | ||
name: hello-world-pod | ||
spec: | ||
containers: | ||
- name: hello | ||
image: busybox | ||
command: ['sh', '-c', 'echo Hello, World! && sleep 30'] | ||
nodeSelector: | ||
NodeGroupType: default | ||
NodePool: default | ||
hub.jupyter.org/node-purpose: user | ||
tolerations: | ||
- key: "hub.jupyter.org/dedicated" | ||
operator: "Equal" | ||
value: "user" | ||
effect: "NoSchedule" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
name: Generate Data Usage Report | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
generate_data_usage_report: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
|
||
- name: Configure AWS credentials | ||
uses: aws-actions/configure-aws-credentials@v3 | ||
with: | ||
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
# TODO param region | ||
aws-region: us-east-2 | ||
|
||
- name: Assume JupyterhubProvisioningRole | ||
# TODO param ProvisioningRoleARN and name ^ | ||
run: | | ||
ROLE_ARN="arn:aws:iam::278212569472:role/JupyterhubProvisioningRole" | ||
CREDS=$(aws sts assume-role --role-arn $ROLE_ARN --role-session-name "GitHubActionsSession") | ||
export AWS_ACCESS_KEY_ID=$(echo $CREDS | jq -r '.Credentials.AccessKeyId') | ||
export AWS_SECRET_ACCESS_KEY=$(echo $CREDS | jq -r '.Credentials.SecretAccessKey') | ||
export AWS_SESSION_TOKEN=$(echo $CREDS | jq -r '.Credentials.SessionToken') | ||
|
||
|
||
- name: Configure kubectl with AWS EKS | ||
# TODO param name, region role-arn | ||
run: | | ||
aws eks update-kubeconfig --name eks-dandihub --region us-east-2 --role-arn arn:aws:iam::278212569472:role/JupyterhubProvisioningRole | ||
|
||
- name: Sanity check | ||
run: | | ||
kubectl get pods -n jupyterhub | ||
|
||
# Step 4: Deploy Hello World Pod from manifest | ||
- name: Deploy Hello World Pod | ||
run: | | ||
kubectl apply -f .github/manifests/hello-world-pod.yaml | ||
|
||
# Step 5: Wait for Pod to Complete | ||
- name: Wait for Hello World Pod to complete | ||
run: | | ||
kubectl wait --for=condition=Ready pod/hello-world-pod --timeout=300s # 5 minutes | ||
continue-on-error: true # Allow the workflow to continue even if this step fails | ||
|
||
# Step 6: Get Pod Logs to verify it ran successfully, only if Step 5 succeeds | ||
- name: Get Hello World Pod logs | ||
run: | | ||
kubectl logs hello-world-pod | ||
if: ${{ success() }} # Only run this step if the previous step was successful | ||
|
||
# Step 7: Cleanup - Always run this step, even if previous steps fail | ||
- name: Delete Hello World Pod | ||
run: | | ||
kubectl delete pod hello-world-pod | ||
if: ${{ always() }} # Always run this step, even if other steps fail |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also run this on a weekly basis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's on PR push just so I can test easily, but yes, 1/week sounds good to me. @kabilar Do you have a preference for what day/time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you. How about Mondays at 6am EST? We can then review the report on Monday mornings.