Update @types/node to ^14

[glensc]

Requires commander update first:

• Bump node engine to 14 #1257 (comment)

[glensc]

Resolving this error:

source/platforms/github/GitHubUtils.ts:92:22 - error TS2769: No overload matches this call.
  Overload 1 of 4, '(arrayBuffer: WithImplicitCoercion<ArrayBuffer | SharedArrayBuffer>, byteOffset?: number | undefined, length?: number | undefined): Buffer', gave the following error.
    Argument of type 'string' is not assignable to parameter of type 'WithImplicitCoercion<ArrayBuffer | SharedArrayBuffer>'.
  Overload 2 of 4, '(str: WithImplicitCoercion<string> | { [Symbol.toPrimitive](hint: "string"): string; }, encoding?: BufferEncoding | undefined): Buffer', gave the following error.
    Argument of type 'string' is not assignable to parameter of type 'BufferEncoding | undefined'.

92       const buffer = Buffer.from(response.data.content, response.data.encoding)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Any ideas what the encoding parameter would be here:

• danger-js/source/platforms/github/GitHubUtils.ts

  Lines 91 to 93 in 9337fac

  	if (isFileContents(response.data) && response.data.content) {
  	const buffer = Buffer.from(response.data.content, response.data.encoding)
  	return buffer.toString()

perhaps the value is always 'base64' there? as I would drop it and use the default?

[fbartho]

@glensc what you could do is add a parser that converts “string” to BufferEncoding

const knownBufferEncodings = [“base64”, TODO]
function verifyEncodingOrThrow(encoding: string): BufferEncoding {
  if (knownBufferEncodings.includes(encoding)) {
    return encoding as BufferEncoding
  }
  throw new Error(`Unsupported response buffer encoding ‘${encoding}’)
}
// Typed in Github, so not tested!

[fbartho]

Closing this PR as we're on 18 at this point. Thank you for contributing