Fix flood rate calculation on 1.1.0 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for the pull request, I checked it out and it seems to be working, but I can't say for certain whether it's perfectly synced or not. I'll have to test it with some others when I have the time, I just want to be sure there's no issues with it and that everyone is synced |
Author
|
Sounds good! Let me know if you run into any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there was an issue with how the flood rate was calculated, it is now correctly calculated as ±
changeAmounteveryUPDATE_RATEms. The client doesn't need to have the rate hardcoded because the it only gets sent changes by the server at the rate of the server.This does however change how the speed is scaled, so for example, a speed of 0.65 will change the elevation by 0.65 units every
UPDATE_RATEms, but I think that's what you initially intended anyway.I have tested these changes on my private server and they appear to be working properly, even with different update rates.
Also, fixed an issue with the automod script that prevented the file watcher from working on network drives.