Bug al responder por controlador las llamadas ajax de los documentos al cambiar el estado#6
Closed
daniel89fg wants to merge 1 commit intomasterfrom
Closed
Bug al responder por controlador las llamadas ajax de los documentos al cambiar el estado#6daniel89fg wants to merge 1 commit intomasterfrom
daniel89fg wants to merge 1 commit intomasterfrom
Conversation
…al cambiar el estado
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where AJAX responses for document status changes were being sent prematurely, preventing error messages from being displayed when extensions (like verifactu) reject the status change.
- Modified
saveDocActionto optionally suppress the JSON response - Updated
saveStatusActionto callsaveDocAction(false)to prevent premature JSON response - Applied the fix consistently across both SalesController and PurchasesController
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Core/Lib/AjaxForms/SalesController.php | Added $sendOk parameter to saveDocAction and updated saveStatusAction to prevent premature JSON responses when changing document status |
| Core/Lib/AjaxForms/PurchasesController.php | Applied the same fix as SalesController to ensure consistent behavior for purchases documents |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuando se cambia el estado de un documento antes de nada guarda el documento y eso hace que la devolución json ya se ejecute, de tal forma que luego al cambiar el estado si una extensión como verifactu quiere devolver false, el estado no se cambia que es lo esperado, pero no muestra los mensajes de error de porque no.
¿Cómo has probado los cambios?
Toda modificación debe haber sido mínimamente probada. Marca o describe las pruebas que has realizado: