feat: add JSON serialization configuration and change SerializerSettings visibility to public #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs visibility to public - Added the `ConfigureJsonSettings` extension to customize JSON serialization settings in `WorkflowOptions`. - Changed `SerializerSettings` visibility from private to public to allow external access to Newtonsoft.Json configuration. Reason: When serializing objects like `Outcome` or `Steps`, some could not be serialized correctly. This change enables adjusting Newtonsoft.Json settings to meet specific requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigureJsonSettingsextension to customize JSON serialization settings inWorkflowOptions.SerializerSettingsvisibility from private to public to allow external access to Newtonsoft.Json configuration.Reason:
When serializing objects like
OutcomeorSteps, some could not be serialized correctly. This change enables adjusting Newtonsoft.Json settings to meet specific requirements.Describe the change
A clear and concise description of what the change is. Any PR submitted without a description of the change will not be reviewed.
Describe your implementation or design
How did you go about implementing the change?
Tests
Did you cover your changes with tests?
Breaking change
Do you changes break compatibility with previous versions?
Additional context
Any additional information you'd like to provide?