Prevent Duplication of Trailing Punctuation in Hyphenated Words Proce…

…ssing
danielhaim1 · Dec 11, 2023 · 4bd4e18 · 4bd4e18
1 parent 721ea18
commit 4bd4e18
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/__tests__/TitleCaser.test.js b/__tests__/TitleCaser.test.js
@@ -11,6 +11,15 @@ const createTest = (description, input, expected) => {
     });
 };
 
+
+describe(`
+    Testing Combined Words that End with Symbol`, () => {
+    createTest('Capitalizes country code "US" correctly in a geopolitical context',
+        'Championing Self-Acceptance: Landmark Initiative',
+        'Championing Self-Acceptance: Landmark Initiative');
+});
+
+
 describe(`
     Testing Acronym/Pronoun of Alpha2/3 Country Codes`, () => {
     createTest('Capitalizes country code "US" correctly in a geopolitical context',

diff --git a/src/TitleCaser.js b/src/TitleCaser.js
@@ -111,10 +111,8 @@ export class TitleCaser {
             const isReplaced = !replacedParts.every((part, index) => part === parts[index]);
 
             // Reassemble the word with the hyphen, reattach trailing punctuation, and return
-            return (
-              (isReplaced ? replacedParts.join("-") : TitleCaserUtils.correctTermHyphenated(word, style)) +
-              trailingPunctuation
-            );
+            const processedWord = isReplaced ? replacedParts.join("-") : TitleCaserUtils.correctTermHyphenated(word, style);
+            return processedWord.endsWith(trailingPunctuation) ? processedWord : processedWord + trailingPunctuation;
           case TitleCaserUtils.hasSuffix(word, style):
             // If the word has a suffix, return the correct casing.
             return TitleCaserUtils.correctSuffix(word, correctTitleCasingList);