-
Notifications
You must be signed in to change notification settings - Fork 7
Bump qs from 6.13.1 to 6.14.1 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Bumps [qs](https://github.com/ljharb/qs) from 6.13.1 to 6.14.1. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.13.1...v6.14.1) --- updated-dependencies: - dependency-name: qs dependency-version: 6.14.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Needs ReviewI recommend reviewing this upgrade before merging because qs is a transitive dependency used by the url package, not directly by this project. While the upgrade includes important security fixes for prototype pollution and DoS vulnerabilities, multiple CI test failures were detected that are unrelated to the qs upgrade itself - they stem from stale API snapshot data and changed external API responses from the Tiltify service. The breaking changes in qs do not affect this codebase since it only uses the built-in URL/URLSearchParams APIs directly. Before merging, the test snapshots should be updated to reflect current API state. Fix SuggestionsWe identified 4 fixable issues in this upgrade.
AI Assistant PromptCopy prompt for AI assistantWhat we checked
Dependency Usage
ChangesThe
View 277 more changes
View 180 more changes in the full analysis References (6)[1]: qs is a transitive dependency of the 'url' package (version 0.11.4), which declares 'qs: ^6.12.3' as a dependency tiltify-api-client/package-lock.json Line 6893 in 49c278f
[2]: Direct dependency 'url: ^0.11.4' is the only package requiring qs - this project does not import or use qs directly tiltify-api-client/package.json Line 25 in 49c278f
[3]: Code uses native URLSearchParams API (urlObj.searchParams.set) instead of qs library for query parameter manipulation Line 200 in 49c278f
[4]: CI test failure: hardcoded expected value '220.00' doesn't match actual API response '425.00' - unrelated to qs upgrade, caused by changed Tiltify API data tiltify-api-client/test/campaign.test.js Line 12 in 49c278f
[5]: qs upgraded from 6.13.1 to 6.14.1, includes security fixes for CVE-2025-15284 (DoS via arrayLimit bypass) and prototype pollution vulnerabilities tiltify-api-client/package-lock.json Line 11287 in 49c278f
[6]: Official changelog documents breaking changes in 6.14.0: stringify throws on cycles, allowDots defaults to false, drops Node <4 support - none affect this codebase since qs is not directly used (source link) fossabot analyzed this PR using dependency research. View this analysis on the web |
Bumps qs from 6.13.1 to 6.14.1.
Changelog
Sourced from qs's changelog.
Commits
3fa11a5v6.14.1a626704[Dev Deps] updatenpmignore3086902[Fix] ensure arrayLength applies to[]notation as wellfc7930e[Dev Deps] updateeslint,@ljharb/eslint-config0b06aac[Dev Deps] update@ljharb/eslint-config64951f6[Refactor]parse: extract key segment splitting helpere1bd259[Dev Deps] update@ljharb/eslint-configf4b3d39[eslint] add eslint 9 optional peer dep6e94d95[Dev Deps] updateeslint,@ljharb/eslint-config,npmignore973dc3c[actions] add workflow permissionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.