-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/todo #4
feat/todo #4
Conversation
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
…ts group branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
depending if there is or not one or more completed or done goal branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
to avoid creating add and other functions for each daily weekly and monthly branch feat/todo
branch feat/todo
because that prop will be added on the Store branch feat/todo
as this prop will be given in the Store branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
branch feat/todo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danifromecuador Hi Buddy! ,
Status: Almost there! 🟠 🟠 🟠
Great Job So far! 🎉
Highlights
- Each section (Daily Goals, Weekly Goals and Monthly Goals) is adding or removing tasks.
- Nice Job rendering the progress shown as percentage.
- Timer plays a sound when time is over
Suggested changes:
Specify action names
You may ask, what is the issue with that? Well, when the user executes an action like add a task, an action name will describe the action that has been executed, not adding action names will make debugging harder and the action would be named as anonymous
in dev tools. as shown in the example below:
The problem will occur if you want do debug, you will not know which action to check because they are named as anonimous
. To prevent this problem specify an action name
on each action that updates the state as shown in the example below:
// todo_logic.js
export const add = (set, input, sliceID) => set((state) => ({
[sliceID]: {
...state[sliceID],
todos: [...state[sliceID].todos, { id: Date.now(), content: input }]
}
}), false, 'todo/add')
after adding an action name
you should be able to debug properly if there is an error:
Summary of pending task
- Specify action names for each action
references
Zustand Issue: Actions Names in Devtools
Zustand Readme # Login Actions
If you think we should take another approach share it with the team!!! Thanks for your effort!
Cheers, and Happy coding!👏👏👏
Please, remember to tag me in your question so I can receive the notification._
src/store/todo_logic.js
Outdated
} | ||
})) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be great to add an action name
here as show on code review example.
src/store/todo_logic.js
Outdated
} | ||
})) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be great to add an action name
here as show on code review example.
src/store/todo_logic.js
Outdated
} | ||
})) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be great to add an action name
here as show on code review example.
src/store/todo_logic.js
Outdated
dones: [] | ||
} | ||
})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be great to add an action name
here as show on code review example.
by passing a third parameter on Store functions when using Redux devtools branch feat/todo
Thanks for the valuable feedback, dear @Diegogagan2587, The required changes were made and now all the actions have a name that will be helpful when debugging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danifromecuador Hi Buddy! ,
Status: Approved! 🟢 🟢 🟢
Great Job So far! 🎉
Highlights
- Each section (Daily Goals, Weekly Goals and Monthly Goals) is adding or removing tasks.
- Nice Job rendering the progress shown as percentage.
- Timer plays a sound when time is over
- Requested Changes were applied.
Suggested changes:
- All suggested changes were applied.
If you think we should take another approach share it with the team!!! Thanks for your effort!
Cheers, and Happy coding!👏👏👏
Please, remember to tag me in your question so I can receive the notification._
Thanks, dear reviewer! |
In this PR, I've:
feat/todo
branchTodo
component that will allow the user to:Todo
component in 3 components:Daily
,Weekly
, andMonthly
goals, those components are being called on theTodos
component and the only one given prop is their corresponding slice of the storeDelete All Completed
button andCompleted percentage indicator
todos.behavior.mp4