Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to specify pkg-config to be used. #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coldtobi
Copy link

For details, please see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=933080

Debian is now using your version of pk2 for the Debian package, and for the previous fork, this issue has been reported that it is not possible to override pkg-config, which is an issue when trying to crosscompile.

This commit makes it possible to override pkg-config when needed, falling back to the pkg-config default if it is not specified.

The Debian bug also mentions CPP, but this is not an issue in your Makefile.

Thanks for considering!

--
tobi

For details, please see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=933080

Debian is now using your version of pk2 for the Debian package, and for
the previous fork, this issue has been reported that it is not possible
to override pkg-config, which is an issue when trying to crosscompile.

This commit makes it possible to override pkg-config when needed,
falling back to the pkg-config default if it is not specified.

The Debian bug also mentions CPP, but this is not an issue in your
Makefile.

Thanks for considering!

--
tobi
@SaturninTheAlien
Copy link

SaturninTheAlien commented Sep 21, 2024

Hi Tobi! 🙂
I understand that you are going to update the PK2 version on the Debian repository. Am I right?
This Github repository is rather dead. PK2 SDL 1.4.5 contains many serious bugs that may never be fixed on this repo.

I made a hard fork of the latest version that is hosted on the repo.
https://github.com/SaturninTheAlien/pk2_greta
It was because daniloc had been inactive for a long time and we thought that my PR will stay on Github forever.
And by coincidence my fork became our main repository nowadays (of course daniloc knowns about it), , the magic of C++. 😂

I invite you to join our community on Discord if you want to talk more about Pekka Kana 2 and its current development status:

https://discord.gg/kqDJfYX

This is currently the primary meeting place of the PisteGamaz community. I hope you have a Discord account. 🙂
We use it also for tracking bugs and new ideas for the Pekka Kana 2. It also used to be used for the same thing in the "PK2 SDL era". The original creator of PK2 - Janne Kivilahti and daniloc are also present on our Discord server.

If you don't want to talk with us on DC and use PK2 from this repo, I suggest you using the version 1.4.3. The later versions (escpecially 1.4.5) are very buggy, often segfault or halt forever.

P. S.
I also love Linux (I use Ubuntu).
I was shocked (positively) when I found PK2 on the apt-get repository. People outside our rather small community still care about the game!
Unfortunately the version was outdated, so I was going to contact probably you, but you were faster. 🙂

--
Saturnin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants