Fix #14413 : Add tag line and column in typedef-info in dump file #8134
+42
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
swasti16
force-pushed
the
swasti/add_tag_line_column
branch
from
3678766 to
4ab71fc
Compare
swasti16
changed the title
swasti16
force-pushed
the
swasti/add_tag_line_column
branch
from
4ab71fc to
812f3f7
Compare
swasti16
force-pushed
the
swasti/add_tag_line_column
branch
from
812f3f7 to
4d5a1f8
Compare
|
danmar
reviewed
Jan 20, 2026
| "}\n"); | ||
| ASSERT_EQUALS(" <typedef-info>\n" | ||
| " <info name=\"fp16\" file=\"file.c\" line=\"2\" column=\"1\" used=\"1\" isFunctionPointer=\"1\">\n" | ||
| " <info name=\"fp16\" file=\"file.c\" line=\"2\" column=\"1\" tagline=\"2\" tagcolumn=\"17\" used=\"1\" isFunctionPointer=\"1\">\n" |
Owner
There was a problem hiding this comment.
as far as I see there is no tagname in any typedef in this example. I think a tagname always follows after a struct/enum keyword.
| typedefInfo.tagColumn = typedefInfo.column; | ||
| typedefInfo.used = false; | ||
| typedefInfo.isFunctionPointer = isFunctionPointer(typeName); | ||
| if (typedefInfo.isFunctionPointer) { |
Owner
There was a problem hiding this comment.
I know we talked about it but I feel skeptic about removing this condition.
Maybe you can search for the tagname like this:
if (Token::Match(typeDef->next(), "struct|enum|class|union %name% {") && typeDef->strAt(2) == typeName->str())
typedefInfo.tagToken = typeDef->tokAt(2);
else
typedefInfo.tagToken = nullptr;
There might be some alternative syntax we want to handle later but we could start with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.