[Optimization] use memoized hashes in Results
to get better lookup times
#500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running Coverband with a significantly big project (I'm currently working on one wtih ~4600 files) may get quite slow. While profiling the project, I found that one big culprit is the
Results
class, where there's a lot of O(n) lookup operations that could but are not currently being memoized.This PR adds such optimization: replacing
find
operations for hash lookups (so only the first lookup ofeager
andruntime
type results is slow - due to building the lookup hash)This optimization alone brought the following load improvement to the coverage report page:
Also tested with both this and #499