Skip to content

Fix some typos #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ __NOTE: the current RCs include below, but this might turn into coverband 6.0__
- added support to download coverage and view data in JSON format
- documentation about working with environment variables
- add cache wiggle to avoid Redis CPU spikes (cache stampede on Redis server)
- make the nocov consistant on the data download and html view
- make the nocov consistent on the data download and html view
- small performance improvements

### Coverband 4.2.3
Expand Down
2 changes: 1 addition & 1 deletion docs/internal_formats.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### Internal Formats

If you are doing development having some documented examples of various internal data formats can be helpfu....
If you are doing development having some documented examples of various internal data formats can be helpful...

The format we get from TracePoint, Coverage, Internal Representations, and Used by SimpleCov for reporting have traditionally varied a bit. We can document the differences in formats here.

Expand Down
2 changes: 1 addition & 1 deletion lib/coverband/adapters/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def expand_report(report)

def merge_reports(new_report, old_report, options = {})
# transparently update from RUNTIME_TYPE = nil to RUNTIME_TYPE = :runtime
# transparent update for format coveband_3_2
# transparent update for format coverband_3_2
old_report = coverage(nil, override_type: nil) if old_report.nil? && type == Coverband::RUNTIME_TYPE
new_report = expand_report(new_report) unless options[:skip_expansion]
keys = (new_report.keys + old_report.keys).uniq
Expand Down
2 changes: 1 addition & 1 deletion lib/coverband/adapters/web_service_store.rb
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def size

###
# Fetch coverband coverage via the API
# This would allow one to expore from the service and move back to the open source
# This would allow one to explore from the service and move back to the open source
# without having to reset coverage
###
def coverage(local_type = nil, opts = {})
Expand Down
2 changes: 1 addition & 1 deletion lib/coverband/collectors/route_tracker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def railtie!

# NOTE: This event was instrumented in Aug 10th 2022, but didn't make the 7.0.4 release and should be in the next release
# https://github.com/rails/rails/pull/43755
# Automatic tracking of redirects isn't avaible before Rails 7.1.0 (currently tested against the 7.1.0.alpha)
# Automatic tracking of redirects isn't available before Rails 7.1.0 (currently tested against the 7.1.0.alpha)
# We could consider back porting or patching a solution that works on previous Rails versions
ActiveSupport::Notifications.subscribe("redirect.action_dispatch") do |name, start, finish, id, payload|
Coverband.configuration.route_tracker.track_key(payload)
Expand Down
2 changes: 1 addition & 1 deletion lib/coverband/configuration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def reset
@coverband_timeout = nil
@service_dev_mode = nil
@service_test_mode = nil
@proces_type = nil
@process_type = nil

@redis_url = nil
@redis_namespace = nil
Expand Down
2 changes: 1 addition & 1 deletion lib/coverband/reporters/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module Coverband
module Reporters
###
# This is the base clase for report generation
# it helps with filtering, normalization, etc for final reprort generation
# it helps with filtering, normalization, etc for final report generation
###
class Base
class << self
Expand Down
2 changes: 1 addition & 1 deletion roadmap.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@ Will be the fully modern release that drops maintenance legacy support in favor

It is important for a project to not only know what problems it is trying to solve, but what things are out of scope. We will start to try to document that here:

* We have in the past tried to add coverage tracking for all gems, this added a lot of complexity and compuation overhead and slowed things down to much. It also was of less value than we had hoped. There are alterntative ways to instrument a shared library to track across multiple applications, and single application gem utilization is easier to handle in a one of basis. It is unlikely we will support that again.
* We have in the past tried to add coverage tracking for all gems, this added a lot of complexity and computation overhead and slowed things down to much. It also was of less value than we had hoped. There are alternative ways to instrument a shared library to track across multiple applications, and single application gem utilization is easier to handle in a one of basis. It is unlikely we will support that again.
2 changes: 1 addition & 1 deletion test/forked/rails_rake_full_stack_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def setup
end

# test 'rake tasks shows coverage properly within eager_loading' do
# this was testing gem data, which we no logner support and I dont know if this makes sense anymre
# this was testing gem data, which we no longer support and I dont know if this makes sense anymre
# end

test "ignored rake tasks don't add coverage" do
Expand Down