Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused views report #560

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

fatkodima
Copy link
Contributor

Currently, the "Unused Views" report is broken, because it always shows 0. This is because we ignore view files for coverage

IGNORE_DEFAULTS = %w[vendor/ .erb$ .slim$ /tmp internal:prelude db/schema.rb]
and when rendering the "Unused Views" report we check if the view is not ignored in
unused_views.reject { |view| @ignore_patterns.any? { |pattern| view.match?(pattern) } }
And they are, because of the mentioned ignoring view files in the @ignore_patterns.

Screenshot 2024-10-18 at 17 48 29

@danmayer danmayer merged commit 0577b10 into danmayer:main Oct 19, 2024
80 checks passed
@danmayer
Copy link
Owner

in 6.1.4 fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants