Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverband:coverage_server rake task not being compatible with Rack 3 / Rackup #570

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

obrie
Copy link
Contributor

@obrie obrie commented Jan 10, 2025

Rack::Server was extracted into a separate gem named rackup: rack/rack#1937

In this gem, Rack::Server is now Rackup::Server, which breaks the coverband:coverage_server rake task:

Rack::Server.start app: Coverband::Reporters::Web.new,

This makes the current version of coverband incompatible with applications that use Rack 3. In addition to this fix, users must add rackup as a gem dependency if it's not already included in their gemset.

I've updated coverband to attempt to load either rackup/server or rack/server, preferring the former since this is what's expected for the latest version of Rack.

I wasn't sure what you might want to have in place in terms of tests, so that's a possible TODO here.

@danmayer
Copy link
Owner

thanks, I appreciate it

@danmayer danmayer merged commit 37fa6ef into danmayer:main Jan 11, 2025
0 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants