Fix coverband:coverage_server rake task not being compatible with Rack 3 / Rackup #570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rack::Server
was extracted into a separate gem namedrackup
: rack/rack#1937In this gem,
Rack::Server
is nowRackup::Server
, which breaks thecoverband:coverage_server
rake task:coverband/lib/coverband/utils/tasks.rb
Line 116 in edd2a90
This makes the current version of coverband incompatible with applications that use Rack 3. In addition to this fix, users must add
rackup
as a gem dependency if it's not already included in their gemset.I've updated coverband to attempt to load either
rackup/server
orrack/server
, preferring the former since this is what's expected for the latest version of Rack.I wasn't sure what you might want to have in place in terms of tests, so that's a possible TODO here.