-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Persist markdown text to local storage #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ndrvndr
wants to merge
5
commits into
dannycahyo:master
Choose a base branch
from
ndrvndr:feat/save-to-local-storage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dc747bb
feat: Persist markdown text to local storage
ndrvndr 5cba844
fix(presentation-context): make PresentationContext SSR-safe and cros…
ndrvndr 8d9720d
refactor(presentation-context): optimize slide navigation and remove …
ndrvndr 3e75254
feat(hooks): add useLocalStorage custom hook
ndrvndr cd42f19
refactor(presentation-context): replace manual localStorage logic wit…
ndrvndr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { useState, useEffect, useCallback } from 'react'; | ||
|
|
||
| const useLocalStorage = <T>( | ||
| key: string, | ||
| defaultValue: T | ||
| ): [T, (value: T | ((val: T) => T)) => void] => { | ||
| const [value, setValue] = useState<T>(defaultValue); | ||
|
|
||
| useEffect(() => { | ||
| try { | ||
| const item = window.localStorage.getItem(key); | ||
| if (item) { | ||
| setValue(JSON.parse(item)); | ||
| } | ||
| } catch (error) { | ||
| console.warn(`Error reading localStorage key "${key}":`, error); | ||
| } | ||
| }, [key]); | ||
|
|
||
| const setStoredValue = useCallback( | ||
| (valueOrFn: T | ((val: T) => T)) => { | ||
| try { | ||
| const newValue = | ||
| valueOrFn instanceof Function ? valueOrFn(value) : valueOrFn; | ||
| setValue(newValue); | ||
| if (typeof window !== 'undefined') { | ||
| window.localStorage.setItem(key, JSON.stringify(newValue)); | ||
| } | ||
| } catch (error) { | ||
| console.error(error); | ||
| } | ||
| }, | ||
| [key, value] | ||
| ); | ||
|
|
||
| return [value, setStoredValue]; | ||
| }; | ||
|
|
||
| export default useLocalStorage; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
initialMarkdownprop is ignored once data exists in localStorage. This could cause confusion if the prop is updated, as the stored value will always take precedence.Consider whether this is the intended behavior. If
initialMarkdownshould only be used when localStorage is empty, this is correct. Otherwise, you may want to add logic to handle updates to theinitialMarkdownprop, or document this behavior clearly.