Improve handling of invalid pids #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we try to return a item id contained within a list stored in the database we currently fail with a 422 Unprocessable Entity. This is not very helpful as the client cannot do anything to address this. To address this we change the process logic to mark a problem with the list id by throwing a more general invalid argument exception. This can then be caught and handled in different situations where this might occur: - For situations where the item id is provided by the client we keep responding with a 422 error. - For situations where the item id is loaded from the database we log the error and return any remaining items. The situation causing this issue is likely caused by a few faulty items being migrated into the database in the initial stage of the project. For v2 we have introduced stricter requirements for data formats. These are being enforced for new data but cause problems with existing data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we try to return a item id contained within a list stored in the database we currently fail with a 422 Unprocessable Entity. This is not very helpful as the client cannot do anything to address this.
To address this we change the process logic to mark a problem with the list id by throwing a more general invalid argument exception. This can then be caught and handled in different situations where this might occur:
The situation causing this issue is likely caused by a few faulty items being migrated into the database in the initial stage of the project. For v2 we have introduced stricter requirements for data formats. These are being enforced for new data but cause problems with existing data.