Develop into release/2024-5-0 #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes the implementation of the `show more` functionality as a utility. Additionally, comprehensive documentation has been written to guide the usage of this component.
Updated to handle multiple tags.
Font's used in the design system are using the japanese version. Since this was causing an issue for me, i decided to change it to the normal version.
I could not see which fonts to use from the figma design, so i have included the ones i thought are correct. Please have a look at that, and comment if you agree or otherwise. I tried different approaches with the CSS layout and ended up with the current grid. Comment if any thoughts on this.
I placed this as a block, since i reckon we should have a block for the event-list-page. I'm not sure if i should call it event-list-page now, or something else, or if it should be kept in /library. Please comment on this.
Updated EventListData DDFFORM-59
I did not remove the old identity-placeholder. Please comment on whether you think i should DDFFORM-59
DDFFORM-59
Included the identity-placeholder (Pseudo version) DDFFORM-59
DDFORM-59
DDFFORM-59
Unrelated to DDFFORM-59
Refactors existing styling that uses extend to use new mixin. Removed old extend placeholder. DDFFORM-59
Refactored everywhere i could find that was using the $color__text-primary-white for non-text related styling. DDFFORM-59
Refactored everywhere i could find that was using the $color__text-primary-black for non-text related styling. DDFFORM-59
Refactored everywhere i could find that was using the $color__text-secondary-gray for non-text related styling. DDFFORM-59
Added both a value for the event date containing only the date, and another for with an ISO formatted date and time for the event time. DDFFORM-59
This is already a part of the show-svg-on-hover mixin and therefore not necessary. DDFFORM-59
The root color cannot use the variable from variables.colors.scss because they are not available to it. DDFFORM-59
The SVG for event list item was being shown at an incorrect breakpoint, because the show-svg-on-hover mixin only hides it beneath the __small breakpoint. Adjusted so that it is now not shown beneath __medium as intended for this design. The mixin could be extended in the future to supports this as a parameter. DDFFORM-59
This particular time element is supposed to contain a range of dates, and this will not work with the current implementation. As such this is removed for now. The other <time> element further down in the code will stay in the template. DDFFORM-59
Added documentation for font generation explaining what has been used to generate the current fonts. Also suggest alternative tools for generating fonts in the future, aswell as marking the importance of ensuring the preloading of fonts in the CMS should remain intact. DDFFORM-59
Implement an simple iframe component using css to ensure 16:9 responsiveness.
Refactor `EventParagraphs` to `Paragraphs` for shared component efficiency.
…ideo-paragraph Add `VideoEmbed` component + Refactor `EventParagraphs`
Up until now, we've added the page background on various individual components, but this is a problem if there is margin between elements, when we want the BG to continue.
- Replace 'show more / less' with '+ / -' to eliminate translation requirements. - Utilize show-more__hidden class instead of inline styling
…enable-tags Implement `show more` functionality as a utility
…pacing implementation of `@include layout-container` and `@include vertical-spacing;` to achieve consistent spacing.
This is a more generic and will be a helpful utility class to have.
…refaktor-arrangement-artikel-med-css-layout-struktur Refactor of `Event` and `Article` components for consistent spacing
Fix pa11y issue with swiper.
This element is a bit tricky, as the card sizes are very dependent on screen real estate. I've tried to put as much logic as possible in SCSS, so it will be plug-n-play without too much Twig/JSX logic. I've also introduced a promo-title component, that I thought I'd need, but turns out I don't, as the title needs to be integrated instead. I've decided to leave it in though, as others might find it useful.
This logic should be implemented in more than one place, e.g., `HorizontalTermLine`
…acing Remove faulty max-width on paragraphs, that should be full width.
…nyhedskomponent Card Grid (nyhedskomponent) element. DDFFORM-127
…e-aria-controls Add dynamic aria-controls attribute for `show-more`
…r-default-date Added default date to dateCalendar
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sass](https://github.com/sass/dart-sass) from 1.69.7 to 1.70.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.69.7...1.70.0) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ithub_actions/actions/cache-4 Bump actions/cache from 3 to 4
…pm_and_yarn/sass-1.70.0 Bump sass from 1.69.7 to 1.70.0
- Make sure 'files' paragraph works in same way as 'links' - Use `.paragraphs__item` instead of `.paragraph`, to avoid that we style on a class name that Drupal might use in situations we are not interested in.
…eaks Paragraph tweaks
…-4-0 Release 2024.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.