Release 2024.32.1 #698
Merged
Release 2024.32.1 #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using an inline SVG it must be encoded. Otherwise browsers may choke on it due to unescaped characters like < and ". At the moment problem can be seen when the Chromatic/Cypress integration tries to generate pages with inline CSS. Without this process fails and CSS is never loaded. To address this we encode the inline CSS using https://yoksel.github.io/url-encoder/. A proper SCSS function to address this would be preferable but I could not find such a thing. We only have two actual instances of inline SVGs to for now it should be OK to just change these. The fact that this is a nice change is also indicated by the fact that we no longer have stylelint issues that has to be ignored.
This commit refactors the underlined title for the `Slider` component. Related pull request: [#1364](danskernesdigitalebibliotek/dpl-cms#1364)
This is a link without icons. DDFFORM-827
…simple-linklist Add story, component and CSS for simpleLink.
Bumps [sass](https://github.com/sass/dart-sass) from 1.77.6 to 1.77.8. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.77.6...1.77.8) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.34.3 to 7.34.4. - [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.34.3...v7.34.4) --- updated-dependencies: - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [chromaui/action](https://github.com/chromaui/action) from 11.5.4 to 11.5.5. - [Release notes](https://github.com/chromaui/action/releases) - [Commits](chromaui/action@v11.5.4...v11.5.5) --- updated-dependencies: - dependency-name: chromaui/action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…pm_and_yarn/sass-1.77.8 Bump sass from 1.77.6 to 1.77.8
…pm_and_yarn/eslint-plugin-react-7.34.4 Bump eslint-plugin-react from 7.34.3 to 7.34.4
…ithub_actions/chromaui/action-11.5.5 Bump chromaui/action from 11.5.4 to 11.5.5
The style element makes Chrome not render the background image. Also it is not really needed as a separate style element. Convert it to attributes on the element instead.
…e-svgs Encode inline SVGs
…sliderheadline-title-underline Refactored Underlined Title for `Slider`
…arch_DDFFORM-678 Add subheading styling for use on web search page. DDFFORM-678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.