Special-case Fifth Avenue Collection #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special casing for "Fifth Avenue, Start to Finish" collection.
This is an awkward fit for other coders because one cross street (Fifth Avenue) is only mentioned as part of the source, and all the streets mentioned in the title are crossing streets or addresses on Fifth Avenue.
It's also easy to geocode because of a previous NYPL Labs project:
https://github.com/NYPL-publicdomain/fifth-avenue
Not super high impact, but these are all wins:
Data update: oldnyc/oldnyc.github.io@c50f7f8