Skip to content

Mvvm koin clean#10

Open
daolq-2712 wants to merge 6 commits intomvvm_koinfrom
mvvm_koin_clean
Open

Mvvm koin clean#10
daolq-2712 wants to merge 6 commits intomvvm_koinfrom
mvvm_koin_clean

Conversation

@daolq-2712
Copy link
Owner

Related Tickets

WHAT

Evidence (Screenshot or Video)

Review Checklist

Category View Point Description Expected Reviewer Answer Self review Reviewer2 (name)
Conventions Does the code follow Sun* coding style and coding conventions? https://github.com/framgia/coding-standards/blob/master/eng/android/coding_convention_android_kotlin.md YES
  • yes
  • yes
  • Redmine Does the ticket follow Sun* Redmine working process? https://github.com/framgia/Training-Guideline/blob/master/WorkingProcess/redmine/redmine.md YES
  • yes
  • yes
  • Documentation Is there any incomplete code? If so, should it be removed or flagged with a suitable marker like ‘TODO’? YES
  • yes
  • yes
  • Notes (Optional)

    (Impacted Areas in Application(List features, api, models or services that this PR will affect))

    (Other notes)

    Repository owner deleted a comment from gitguardian bot Apr 1, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant