Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update broken image path to correct one #267

Merged
merged 3 commits into from
Sep 18, 2024
Merged

update broken image path to correct one #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c44e55
Update TopShot.cdc
annatangzhao Sep 18, 2024
f5ad196
regenerate asset
judezhu Sep 18, 2024
37658b9
fixed test
judezhu Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/TopShot.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1689,7 +1689,7 @@ access(all) contract TopShot: NonFungibleToken {
)
let squareImage = MetadataViews.Media(
file: MetadataViews.HTTPFile(
url: "https://nbatopshot.com/static/img/og/og.png"
url: "https://nbatopshot.com/static/favicon/favicon.svg"
),
mediaType: "image/png"
)
Expand Down
6 changes: 3 additions & 3 deletions lib/go/contracts/internal/assets/assets.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/go/test/subedition_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ func TestSubeditions(t *testing.T) {
expectedPublicPath := "/public/MomentCollection"
expectedCollectionName := "NBA-Top-Shot"
expectedCollectionDescription := "NBA Top Shot is your chance to own, sell, and trade official digital collectibles of the NBA and WNBA's greatest plays and players"
expectedCollectionSquareImage := "https://nbatopshot.com/static/img/og/og.png"
expectedCollectionSquareImage := "https://nbatopshot.com/static/favicon/favicon.svg"
expectedCollectionBannerImage := "https://nbatopshot.com/static/img/top-shot-logo-horizontal-white.svg"
expectedRoyaltyReceiversCount := 1
expectedTraitsCount := 6
Expand Down
2 changes: 1 addition & 1 deletion lib/go/test/topshot_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ func TestMintNFTs(t *testing.T) {
expectedPublicPath := "/public/MomentCollection"
expectedCollectionName := "NBA-Top-Shot"
expectedCollectionDescription := "NBA Top Shot is your chance to own, sell, and trade official digital collectibles of the NBA and WNBA's greatest plays and players"
expectedCollectionSquareImage := "https://nbatopshot.com/static/img/og/og.png"
expectedCollectionSquareImage := "https://nbatopshot.com/static/favicon/favicon.svg"
expectedCollectionBannerImage := "https://nbatopshot.com/static/img/top-shot-logo-horizontal-white.svg"
expectedRoyaltyReceiversCount := 1
expectedTraitsCount := 7
Expand Down
Loading