Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX for changing chats in creators page #87

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

teodorus-nathaniel
Copy link
Contributor

@teodorus-nathaniel teodorus-nathaniel commented Nov 3, 2023

Use setConfig instead of init every single grill chat instance
Also, when its loading, it hides the iframe until its finished redirecting

Other Change

Change staking info saga to use takeLeading instead of takeLatest
Reason: to speed up the result process (use the first time it was fetched) and reduce unnecessary api calls

@teodorus-nathaniel teodorus-nathaniel merged commit 43529f3 into main Nov 3, 2023
1 check passed
@teodorus-nathaniel teodorus-nathaniel deleted the improvement/iframe branch November 3, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants