Move from variant map to array (rebased)

[dappnodedev]

This PR overrides #440, as code base was out of date.

It aims to move from type:

interface BuildVariantsMap {
    [variant: string]: {
      // Compose file
      compose: Compose;
      
      // Manifest-related
      manifest: Manifest;
      manifestFormat: ManifestFormat;
      
      // File paths
      releaseDir: string;
      composePaths: string[];
      
      // Package information
      images: PackageImage[];
      architectures: Architecture[];
   }
}

to type:

interface PackageToBuildProps {
  variant: string | null;

  // Compose file
  compose: Compose;

  // Manifest-related
  manifest: Manifest;
  manifestFormat: ManifestFormat;

  // File paths
  releaseDir: string;
  composePaths: ComposePaths[];
  manifestPaths: ManifestPaths[];

  // Package information
  images: PackageImage[];
  architectures: Architecture[];
}[]

[github-actions]

Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 86edf17

This is a development version and should only be installed for testing purposes.

1. Package dappnodesdk.public.dappnode.eth

Install link

Hash: /ipfs/QmcUPPYL5eUg2Cm6Wzkf7s8vzdYwm8tf3EWrqMKe98obVj

(by dappnodebot/build-action)

[pablomendezroyo]

Isnt a bit confusing the name variantsStr? what about using variantsName ?

[dappnodedev]

It's the string you receive from console after flag --variants, like:
--variants mainnet,holesky,lukso

[pablomendezroyo]

What are your intentions allowing null if null means something either add a comment or find a way to define such intention with a boolean

[pablomendezroyo]

also, what means exactly variant

[dappnodedev]

I added a comment. variant could be mainnet, testnet, holesky... the value that makes one package differ from another in the same repo. It must be equal to the directory where that variant files are defined. For example, if you want to build the holesky and mainnet variants of a package, you would run:

`dappnodesdk build --variants-dir "./package_variants" --variants "mainnet,holesky"

And your repo must include these files:

.
├── avatar.png
├── dappnode_package.json
├── docker-compose.yml
...
├── package_variants
│   ├── holesky
│   │   ├── dappnode_package.json
│   │   └── docker-compose.yml
│   └── mainnet
│       ├── dappnode_package.json
│       └── docker-compose.yml
└── README.md

[pablomendezroyo]

same as below. What means variant? what is the intention behind the scenes allowing null

[dappnodedev]

Variant meaning is explained here: #443 (comment)

It can be null because legacy format packages (with full compose and manifest files in the root of the repo) have no variant so it makes sense that it is explicitly null

[pablomendezroyo]

why allowing null? ist better the usage of a boolean?

[dappnodedev]

If I added a boolean, variant would still have to be undefined or null for single packages, so I would say it does not provide any value.