Skip to content

Commit

Permalink
do not return error on nil, skip bad versions
Browse files Browse the repository at this point in the history
Signed-off-by: Anton Troshin <anton@diagrid.io>
  • Loading branch information
antontroshin committed Nov 22, 2024
1 parent fdab315 commit 74e4d6f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/version/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func GetLatestReleaseGithub(githubURL string) (string, error) {
// just a safety check to make sure we don't get a nil version.
// all errors should be handled above.
if cur == nil {
return "", fmt.Errorf("failed to parse version %s, resulted in nil version", release.TagName)
continue
}
if cur.GreaterThan(latestVersion) {
latestVersion = cur
Expand Down

0 comments on commit 74e4d6f

Please sign in to comment.