add image pull policy #1462
Merged
add image pull policy #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filinto Duran <filinto@diagrid.io>
filintod
force-pushed
the
filinto/add-image-pull-policy
branch
from
a170e7c to
448ecae
Compare
Signed-off-by: Filinto Duran <filinto@diagrid.io>
|
@artursouza @antontroshin please check |
antontroshin
previously approved these changes
Nov 14, 2024
elena-kolevska
previously approved these changes
Nov 14, 2024
Signed-off-by: Filinto Duran <filinto@diagrid.io>
filintod
dismissed stale reviews from elena-kolevska and antontroshin
via
9783d1b
|
@antontroshin @elena-kolevska could you re-approved? I added the feedback from @antontroshin |
elena-kolevska
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Can we add a little unit test pls?
https://github.com/dapr/cli/blob/master/pkg/runfileconfig/run_file_config_parser_test.go
Signed-off-by: Filinto Duran <filinto@diagrid.io>
|
@elena-kolevska please take another look. thx |
elena-kolevska
requested changes
Nov 14, 2024
elena-kolevska
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Super helpful for local development @filintod , thank you very much!
antontroshin
approved these changes
Nov 15, 2024
3 tasks
yaron2
approved these changes
Dec 23, 2024
|
Upgrade tests are failing, is this related? |
|
@yaron2 I've re-run the tests, and they all passed, except for regular Podman failure on macOS, which is on my plate for the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently one cannot use the kubernetes run when using an image loaded to a kind cluster as the image pull policy is hard coded to Always. This changes it to make it configurable.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1463
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: