add image pull policy

pkg/kubernetes/run.go

@@ -297,7 +297,7 @@ func createDeploymentConfig(client versioned.Interface, app runfileconfig.App) d
 						Name:            app.AppID,
 						Image:           app.ContainerImage,
 						Env:             getEnv(app),
-						ImagePullPolicy: corev1.PullAlways,
+						ImagePullPolicy: corev1.PullPolicy(app.ContainerImagePullPolicy),
 					},
 				},
 			},

pkg/runfileconfig/run_file_config.go

@@ -41,8 +41,9 @@ type RunFileConfig struct {
 
 // ContainerConfiguration represents the application container configuration parameters.
 type ContainerConfiguration struct {
-	ContainerImage string `yaml:"containerImage"`
-	CreateService  bool   `yaml:"createService"`
+	ContainerImage           string `yaml:"containerImage"`
+	ContainerImagePullPolicy string `yaml:"containerImagePullPolicy"`
+	CreateService            bool   `yaml:"createService"`
 }
 
 // App represents the configuration options for the apps in the run file.

pkg/runfileconfig/run_file_config_parser.go

@@ -26,6 +26,8 @@
 	"gopkg.in/yaml.v2"
 )
 
+var imagePullPolicyValuesAllowed = []string{"Always", "Never", "IfNotPresent"}
+
 // Parse the provided run file into a RunFileConfig struct.
 func (a *RunFileConfig) parseAppsConfig(runFilePath string) error {
 	var err error
@@ -97,6 +99,15 @@
 		if len(strings.TrimSpace(a.Apps[i].ResourcesPath)) > 0 {
 			a.Apps[i].ResourcesPaths = append(a.Apps[i].ResourcesPaths, a.Apps[i].ResourcesPath)
 		}
+
+		// Check containerImagePullPolicy is valid
+		if a.Apps[i].ContainerImagePullPolicy != "" {
+			if !utils.Contains(imagePullPolicyValuesAllowed, a.Apps[i].ContainerImagePullPolicy) {
+				return fmt.Errorf("invalid containerImagePullPolicy: %s, allowed values: %s", a.Apps[i].ContainerImagePullPolicy, strings.Join(imagePullPolicyValuesAllowed, ", "))
+			}
+		} else {
+			a.Apps[i].ContainerImagePullPolicy = "Always"
+		}
 	}
 	return nil
 }

pkg/runfileconfig/run_file_config_parser_test.go

@@ -32,9 +32,12 @@
 	runFileForPrecedenceRuleDaprDir = filepath.Join(".", "testdata", "test_run_config_precedence_rule_dapr_dir.yaml")
 	runFileForLogDestination        = filepath.Join(".", "testdata", "test_run_config_log_destination.yaml")
 	runFileForMultiResourcePaths    = filepath.Join(".", "testdata", "test_run_config_multiple_resources_paths.yaml")
+
+	runFileForContainerImagePullPolicy        = filepath.Join(".", "testdata", "test_run_config_container_image_pull_policy.yaml")
+	runFileForContainerImagePullPolicyInvalid = filepath.Join(".", "testdata", "test_run_config_container_image_pull_policy_invalid.yaml")
 )
 
 func TestRunConfigFile(t *testing.T) {
 	t.Parallel()
 	t.Run("test parse valid run template", func(t *testing.T) {
 		appsRunConfig := RunFileConfig{}
@@ -144,6 +147,34 @@
 		}
 	})
 
+	t.Run("test containerImagePullPolicy", func(t *testing.T) {
+		t.Run("default value is Always", func(t *testing.T) {
+			config := RunFileConfig{}
+			config.parseAppsConfig(validRunFilePath)
+			err := config.validateRunConfig(runFileForPrecedenceRuleDaprDir)
+			assert.NoError(t, err)
+			assert.Equal(t, "Always", config.Apps[0].ContainerImagePullPolicy)
+			assert.Equal(t, "Always", config.Apps[1].ContainerImagePullPolicy)
+		})
+
+		t.Run("custom value is respected", func(t *testing.T) {
+			config := RunFileConfig{}
+			config.parseAppsConfig(runFileForContainerImagePullPolicy)
+			err := config.validateRunConfig(runFileForContainerImagePullPolicy)
+			assert.NoError(t, err)
+			assert.Equal(t, "IfNotPresent", config.Apps[0].ContainerImagePullPolicy)
+			assert.Equal(t, "Always", config.Apps[1].ContainerImagePullPolicy)
+		})
+
+		t.Run("invalid value is rejected", func(t *testing.T) {
+			config := RunFileConfig{}
+			config.parseAppsConfig(runFileForContainerImagePullPolicyInvalid)
+			err := config.validateRunConfig(runFileForContainerImagePullPolicyInvalid)
+			assert.Error(t, err)
+			assert.Contains(t, err.Error(), "invalid containerImagePullPolicy: Invalid, allowed values: Always, Never, IfNotPresent")
+		})
+	})
+
 	t.Run("test precedence logic with daprInstallDir for resources-path and dapr config file", func(t *testing.T) {
 		config := RunFileConfig{}
 

pkg/runfileconfig/testdata/test_run_config_container_image_pull_policy.yaml

@@ -0,0 +1,24 @@
+version: 1
+common:
+  resourcesPath: ./app/resources
+  appProtocol: HTTP
+  appHealthProbeTimeout: 10
+  env:
+    DEBUG: false
+    tty: sts
+apps:
+  - appDirPath: ./webapp/
+    resourcesPath: ./resources
+    configFilePath: ./config.yaml
+    appPort: 8080
+    appHealthProbeTimeout: 1
+    containerImagePullPolicy: IfNotPresent
+    containerImage: ghcr.io/dapr/dapr-workflows-python-sdk:latest
+  - appID: backend
+    appDirPath: ./backend/
+    appProtocol: GRPC
+    appPort: 3000
+    unixDomainSocket: /tmp/test-socket
+    env:
+      DEBUG: true
+    containerImage: ghcr.io/dapr/dapr-workflows-csharp-sdk:latest

pkg/runfileconfig/testdata/test_run_config_container_image_pull_policy_invalid.yaml

@@ -0,0 +1,24 @@
+version: 1
+common:
+  resourcesPath: ./app/resources
+  appProtocol: HTTP
+  appHealthProbeTimeout: 10
+  env:
+    DEBUG: false
+    tty: sts
+apps:
+  - appDirPath: ./webapp/
+    resourcesPath: ./resources
+    configFilePath: ./config.yaml
+    appPort: 8080
+    appHealthProbeTimeout: 1
+    containerImagePullPolicy: Invalid
+    containerImage: ghcr.io/dapr/dapr-workflows-python-sdk:latest
+  - appID: backend
+    appDirPath: ./backend/
+    appProtocol: GRPC
+    appPort: 3000
+    unixDomainSocket: /tmp/test-socket
+    env:
+      DEBUG: true
+    containerImage: ghcr.io/dapr/dapr-workflows-csharp-sdk:latest