Proof of upgrade failure #1360
Proof of upgrade failure #1360
Conversation
install/upgrade Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1360 +/- ##
=======================================
Coverage 22.55% 22.55%
=======================================
Files 40 40
Lines 4758 4758
=======================================
Hits 1073 1073
Misses 3607 3607
Partials 78 78 ☔ View full report in Codecov by Sentry. |
| for _, owner := range pod.OwnerReferences { | ||
| if owner.Kind == "ReplicaSet" && owner.Name == replica { | ||
| if len(pod.Spec.Containers) != 2 || pod.Spec.Containers[1].Name != "daprd" { | ||
| return false, errors.New("expected injected daprd container") |
There was a problem hiding this comment.
Hi @JoshVanL, the upgrade tests are failing with this error, could you please check?
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
PR includes only e2e test to prove fix in #1359