[WIP] Add --waitTimeout flag to dapr stop command #1363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nikitasarawgi, welcome to Dapr 👋🏻 Could you please fix the DCO check? https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work |
Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
* Updates the Dapr version to v1.12.0-rc.1 Signed-off-by: joshvanl <me@joshvanl.dev> * Use correct rc tag name Signed-off-by: joshvanl <me@joshvanl.dev> * Fix string match on `HTTP server is running on port x` Signed-off-by: joshvanl <me@joshvanl.dev> * Fix error string check for `internal gRPC server` Signed-off-by: joshvanl <me@joshvanl.dev> * Update dapr/dapr to 1.12.0-rc.3 Signed-off-by: joshvanl <me@joshvanl.dev> * Rolling restart the sidecar injector during a restart Signed-off-by: joshvanl <me@joshvanl.dev> * Linting Signed-off-by: joshvanl <me@joshvanl.dev> * Fix string matching on dapr app output logs Signed-off-by: joshvanl <me@joshvanl.dev> * Increase e2e tests `20m` -> `25m` Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev> Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com> Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
* update dapr runtime to v1.12.0 Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * fix dashboard version Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> --------- Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
Signed-off-by: hdget <hdget@qq.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Shubham Sharma <shubhash@microsoft.com> Co-authored-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.15.0 to 0.17.0. - [Commits](golang/net@v0.15.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.57.0 to 1.57.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.57.0...v1.57.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
nikitasarawgi
force-pushed
the
stopWait
branch
from
00b15d0 to
98e1950
Compare
Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new --waitTimeout flag to the dapr stop command - This flag allows users to specify a timeout duration in seconds, which determines the maximum time the command will wait for the process to exit gracefully. If the process remains active after this timeout, the command will forcefully terminate it.
The default --waitTimeout value is set to 15 seconds.
WIP - This is implemented only for linux for now. Currently learning how windows event signals work.
Unit tests run successfully.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1160
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: