Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed Scheduler CLI Changes #1405

Merged
merged 9 commits into from
Jul 3, 2024
Merged

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented May 17, 2024

Dapr init, run, and uninstall with Scheduler.

Issue reference

dapr/dapr#7605

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle cicoyle changed the title Wip: Distributed Scheduler CLI Changes WEP: Distributed Scheduler CLI Changes May 17, 2024
@cicoyle cicoyle changed the title WEP: Distributed Scheduler CLI Changes WIP: Distributed Scheduler CLI Changes May 17, 2024
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@mikeee mikeee mentioned this pull request May 28, 2024
43 tasks
artursouza and others added 2 commits May 29, 2024 17:32
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Fixes install and uninstall of scheduler in standalone mode.
@cicoyle cicoyle marked this pull request as ready for review June 8, 2024 02:22
@cicoyle cicoyle requested review from a team as code owners June 8, 2024 02:22
@cicoyle
Copy link
Contributor Author

cicoyle commented Jun 8, 2024

Big thank you to @artursouza for the majority of the efforts for this change 🎉

@cicoyle
Copy link
Contributor Author

cicoyle commented Jun 8, 2024

Notes for the future to remember:

Planning to add to the cli these commands to a following release:

dapr job schedule --name=myjob --app-id=myapp --schedule "@hourly" --data '{"key":"value"}' --repeats 1
dapr job get --name=myjob --app-id=myapp
dapr job delete --name=myjob --app-id=myapp

@cicoyle cicoyle changed the title WIP: Distributed Scheduler CLI Changes Distributed Scheduler CLI Changes Jun 8, 2024
@mikeee
Copy link
Member

mikeee commented Jun 15, 2024

I'm not seeing the scheduler initialized - I've created a custom installerbundle with the scheduler added to the dapr docker image. There are no errors/warnings logged

./dist/
./dist/dashboard_linux_amd64.tar.gz
./dist/injector_linux_amd64.tar.gz
./dist/scheduler_linux_amd64.tar.gz
./dist/daprd_linux_amd64.tar.gz
./dist/sentry_linux_amd64.tar.gz
./dist/placement_linux_amd64.tar.gz
./dist/operator_linux_amd64.tar.gz
./docker/
./docker/daprio-dapr-0.0.0-dev.tar.gz
./details.json
./dapr
ℹ️  Removing Dapr from your machine...
⚠  WARNING: /home/runner/.dapr/bin does not exist
⚠  WARNING: dapr_placement container does not exist
⚠  WARNING: dapr_scheduler container does not exist
⚠  WARNING: dapr_redis container does not exist
⚠  WARNING: dapr_zipkin container does not exist
⚠  WARNING: /home/runner/.dapr does not exist
✅  Dapr has been removed successfully
⌛  Making the jump to hyperspace...
⚠  Local bundle installation using --from-dir flag is currently a preview feature and is subject to change. It is only available from CLI version 1.7 onwards.
ℹ️  Installing runtime version 0.0.0-dev

Dapr runtime installed to /home/runner/.dapr/bin, you may run the following to add it to your path if you want to run daprd directly:
    export PATH=$PATH:/home/runner/.dapr/bin
Loaded image: daprio/dapr:0.0.0-dev
✅  Extracting binaries and setting up components...
✅  Extracted binaries and completed components set up.
ℹ️  daprd binary has been installed to /home/runner/.dapr/bin.
ℹ️  dapr_placement container is running.
ℹ️  Use `docker ps` to check running containers.
✅  Success! Dapr is up and running. To get started, go here: https://aka.ms/dapr-getting-started```

Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@artursouza artursouza force-pushed the feat-dist-scheduler branch from 0b344f4 to c2e30fa Compare June 27, 2024 19:27
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@artursouza artursouza force-pushed the feat-dist-scheduler branch from c2e30fa to 9768c63 Compare June 27, 2024 19:33
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@mikeee mikeee mentioned this pull request Jul 2, 2024
@yaron2 yaron2 merged commit fd1d8e8 into dapr:master Jul 3, 2024
27 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @cicoyle Thanks Cassie!

Copy link

holopin-bot bot commented Aug 15, 2024

Congratulations @cicoyle, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzv8dtm642510cli68vs37e7

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants