Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduler standalone CLI address remove on certain versions, edge or dev #1479

Open
wants to merge 3 commits into
base: release-1.15
Choose a base branch
from

Conversation

antontroshin
Copy link
Contributor

Description

In standalone mode scheduler-host-address was not set by default to localhost.
Working locally on "dev" version was removing this argument from dapr run command

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Anton Troshin <anton@diagrid.io>
Signed-off-by: Anton Troshin <anton@diagrid.io>
mikeee
mikeee previously approved these changes Jan 24, 2025
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Anton Troshin <anton@diagrid.io>
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-1.15@953c4a2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/standalone/standalone.go 0.00% 19 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.15    #1479   +/-   ##
===============================================
  Coverage                ?   21.32%           
===============================================
  Files                   ?       44           
  Lines                   ?     5154           
  Branches                ?        0           
===============================================
  Hits                    ?     1099           
  Misses                  ?     3971           
  Partials                ?       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants