Adding tutorial based on hello-kubernetes #52
Conversation
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
|
@yaron2 @alicejgibbons I need someone to approve this PR :) |
| ``` | ||
| { "orderId": "42" } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I would really encourage adding a K8s command here illustrate where the dapr instances are running. Given these are Dapr deployments and this is a default 3 node Kind cluster, you can show that these instance may be running on different nodes compared to where the app is running. In other words, how do you teach someone that Dapr Shared is installed correctly, or how do I look at a cluster and see that this has dapr shared running on it compared to having side car deployment?
There was a problem hiding this comment.
Agree here! Daprd is being deployed as a Deployment right? I was unsure if deployment or DS initially.
Maybe just add a screenshot of the Daprd's running on the cluster at least?
tutorial/README.md
Outdated
There was a problem hiding this comment.
Would it still be useful to add this (pizza demo) as another example in the repo under and example section or not?
There was a problem hiding this comment.
can we close this one first and then we can align the Pizza tutorial to follow the same approach?
There was a problem hiding this comment.
Agree on this and told Salaboy this but the pizza one was failing right now.
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
| Let's create a new Dapr Shared instance for the Node (`nodeapp`) application: | ||
|
|
||
| ```sh | ||
| helm install nodeapp-shared oci://docker.io/daprio/dapr-shared-chart --set shared.appId=nodeapp |
There was a problem hiding this comment.
I feel like the helm chart here abstracts what is actually happening too much. Can you add a link to the helm chart at least so that users can inspect the values?
| ``` | ||
| { "orderId": "42" } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Agree here! Daprd is being deployed as a Deployment right? I was unsure if deployment or DS initially.
Maybe just add a screenshot of the Daprd's running on the cluster at least?
tutorial/README.md
Outdated
There was a problem hiding this comment.
Agree on this and told Salaboy this but the pizza one was failing right now.
|
This good to be merged? @salaboy |
|
I was waiting for an approval |
This PR adds a tutorial that uses the same example as the official quickstart title hello-kubernetes but introducing Dapr Shared. To merge this PR first we need to make sure that those examples support setting a remote Dapr Endpoint -> dapr/quickstarts#1030