Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
  • Loading branch information
tmacam and msfussell authored Jul 5, 2023
1 parent ba53578 commit 53b7060
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion daprdocs/content/en/reference/api/secrets_api.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ GET http://localhost:<daprPort>/v1.0/secrets/<secret-store-name>/<name>?metadata
```

Observe that not all secret stores support the same set of parameters. For example:
- Hashicorp Vault, GCP Secret Manager, and AWS Secret Manager support the `version_id` parameter
- Hashicorp Vault, GCP Secret Manager and AWS Secret Manager support the `version_id` parameter
- Only AWS Secret Manager supports the `version_stage` parameter
- Only Kubernetes Secrets supports the `namespace` parameter
Check each [secret store's documentation]({{< ref supported-secret-stores.md >}}) for the list of supported parameters.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ The following [optional query parameters]({{< ref "secrets_api#query-parameters"

Query Parameter | Description
--------- | -----------
`metadata.namespace`| The namespace of the secret. If not specified, the namespace of the pod will be used.
`metadata.namespace`| The namespace of the secret. If not specified, the namespace of the pod is used.

## Related links
- [Secrets building block]({{< ref secrets >}})
Expand Down

0 comments on commit 53b7060

Please sign in to comment.