Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pub/sub] add programmatic description to how-to #2290

Closed
wants to merge 7 commits into from

Conversation

hhunter-ms
Copy link
Collaborator

Signed-off-by: Hannah Hunter hannahhunter@microsoft.com

Description

Added description of programmatic subscriptions to the how-to.

Issue reference

PR will close: #2052

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms requested review from a team as code owners March 23, 2022 19:49
@msfussell msfussell modified the milestone: 1.7 Mar 24, 2022
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Mar 30, 2022
@msfussell
Copy link
Member

@hhunter-ms Although this is accurate, this is mostly a copy from the https://docs.dapr.io/developing-applications/building-blocks/pubsub/howto-route-messages/#programmatic-subscription topic. It would be better that the programmatic examples were the same as the declarative ones, so that there is some consistency.

@msfussell msfussell removed the stale label Apr 1, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 7, 2022
@hhunter-ms
Copy link
Collaborator Author

@msfussell I took at stab at this, but definitely would like a review.

also need a Java example for programmatic subscriptions... I don't know Java well enough to create one from scratch.

@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 15, 2022
@github-actions github-actions bot closed this Apr 22, 2022
@hhunter-ms hhunter-ms reopened this Apr 25, 2022
@github-actions github-actions bot closed this May 3, 2022
@yaron2 yaron2 reopened this May 3, 2022
@github-actions github-actions bot closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pub/Sub subscriptions need to be revised
4 participants