Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dubbo] component spec #3438

Closed
wants to merge 10 commits into from
Closed

[dubbo] component spec #3438

wants to merge 10 commits into from

Conversation

hhunter-ms
Copy link
Collaborator

Description

Taking a stab at the bindings.alicloud.dubbo component spec.

Issue reference

PR will close: #2479

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms added this to the 1.11 milestone May 18, 2023
@hhunter-ms hhunter-ms self-assigned this May 18, 2023
@hhunter-ms hhunter-ms requested review from a team as code owners May 18, 2023 17:10
@msfussell
Copy link
Member

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
hhunter-ms and others added 2 commits May 18, 2023 16:29
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

| Field | Required | Binding support | Details | Example |
|--------------------|:--------:|------------|-----|---------|
| `group` | N | Output | | `""` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need examples and defaults here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msfussell msfussell requested a review from berndverst May 24, 2023 04:12
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label May 30, 2023
@hhunter-ms hhunter-ms removed the stale label Jun 6, 2023
@hhunter-ms hhunter-ms modified the milestones: 1.11, 1.12 Jun 6, 2023
@msfussell msfussell modified the milestones: 1.12, 1.11 Jun 8, 2023
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jun 15, 2023
@github-actions github-actions bot closed this Jun 29, 2023
@ItalyPaleAle
Copy link
Contributor

Should be re-opened?

@hhunter-ms hhunter-ms reopened this Jul 21, 2023
@hhunter-ms hhunter-ms removed the stale label Jul 21, 2023
@msfussell
Copy link
Member

@ItalyPaleAle @berndverst - Can you help review and resolve this PR?

@github-actions
Copy link

Stale PR, paging all reviewers

Signed-off-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Aug 7, 2023
@github-actions github-actions bot closed this Aug 15, 2023
@yaron2 yaron2 reopened this Aug 15, 2023
@github-actions github-actions bot closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add document for dubbo output binding
5 participants