Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JetStream] Add example for competing consumer pattern #3586

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

hhunter-ms
Copy link
Collaborator

@hhunter-ms hhunter-ms commented Jun 27, 2023

Description

Issue reference

PR will close: #3382

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms requested review from a team as code owners June 27, 2023 20:07
@hhunter-ms hhunter-ms self-assigned this Jun 27, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jul 3, 2023
@msfussell
Copy link
Member

msfussell commented Jul 3, 2023

@bruth @berndverst _ Please review based on this (dapr/components-contrib#2835)

@github-actions github-actions bot removed the stale label Jul 4, 2023
Copy link
Contributor

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvement suggestions.

hhunter-ms and others added 2 commits July 5, 2023 12:20
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
Copy link
Collaborator Author

@Jarema thanks for the review! let me know if my updates help? I tried to stick with the durableName and queueGroupName pattern from the earlier example in this doc, but I can update again if still not a good example...

@github-actions
Copy link

Stale PR, paging all reviewers

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 106f7e5 into dapr:v1.11 Jul 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Jetstream docs to show examples of competing consumer pattern with dynamic values
3 participants