Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pub/sub] Clarify component name and add note for SNS/SQS #3611

Merged
merged 10 commits into from
Jul 27, 2023

Conversation

hhunter-ms
Copy link
Collaborator

Description

Try to clarify docs due to questions around:

  • Component name in the how-to - incorrect per RabbitMQ spec
  • Add little note about how the SNS/SQS component generates SNS and provisions SQS

Issue reference

PR will close: #1554

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms self-assigned this Jul 13, 2023
@hhunter-ms hhunter-ms requested review from a team as code owners July 13, 2023 20:07
@hhunter-ms
Copy link
Collaborator Author

@amimimor could you review?

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit cfb7848 into dapr:v1.11 Jul 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component name usage isn't clear
3 participants