Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guestConfig metadata doc for wasm middleware #3632

Merged
merged 8 commits into from
Aug 7, 2023

Conversation

Taction
Copy link
Member

@Taction Taction commented Jul 25, 2023

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Add guestConfig metadata doc for wasm middleware.

Issue reference

Please reference the issue this PR will close: #3617

Signed-off-by: zhangchao <zchao9100@gmail.com>
Signed-off-by: zhangchao <zchao9100@gmail.com>
@Taction Taction requested review from a team as code owners July 25, 2023 14:59
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review

@msfussell
Copy link
Member

@Taction - Can you take a look at these few updates? Thx

Taction and others added 3 commits August 2, 2023 13:55
…iddleware/middleware-wasm.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Taction <zchao9100@gmail.com>
…iddleware/middleware-wasm.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Taction <zchao9100@gmail.com>
…iddleware/middleware-wasm.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Taction <zchao9100@gmail.com>
@Taction
Copy link
Member Author

Taction commented Aug 2, 2023

Thanks for the review and the remind. Fixed.

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
@hhunter-ms hhunter-ms merged commit 9ded13d into dapr:v1.11 Aug 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs for http wasm middleware guest config
3 participants