[WIP] Update service invocation examples #3642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
hhunter-ms
changed the title
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
halspang
reviewed
Jul 27, 2023
...developing-applications/building-blocks/service-invocation/howto-invoke-discover-services.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
msfussell
reviewed
Jul 31, 2023
...developing-applications/building-blocks/service-invocation/howto-invoke-discover-services.md
Outdated
Show resolved
Hide resolved
| orderId = random.randint(1, 1000) | ||
| #Invoke a service | ||
| result = requests.post( | ||
| url='%s/orders' % (base_url), |
There was a problem hiding this comment.
In all the examples you are now showing how the /orders method on the order processing service is called. If that is the change then
1)The diagram at the start needs to change to be more like the Quickstart. In other words Checkout calls order processing, not the other way around currently in this article.
2) This Javascript example still shows checkout and not orders on the order-processing service
3) Check any changes in the other code
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
|
Stale PR, paging all reviewers |
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
|
Stale PR, paging all reviewers |
yaron2
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update code examples in service invocation how-to for using HTTP clients to align with quickstarts
Update dapr run commands to match
Issue reference
PR will close: #3599