Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace 'durable reminders' by 'Actor reminders' #3889

Conversation

alfred-mikhael
Copy link

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Replaced "Retries are internally implemented using durable reminders" with "Retries are internally implemented using Actor reminders" in this article

Issue reference

Addresses issue #3805

Signed-off-by: Alfred Mikhael <alfred.mikhael@mail.utoronto.ca>
@alfred-mikhael alfred-mikhael requested review from a team as code owners November 29, 2023 16:14
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msfussell
Copy link
Member

@alfred-mikhael - Durable timers are internally backed by internal actor reminders - "There are no limits to the maximum duration of durable timers, which are internally backed by internal actor reminders."
So not sure this PR changes much, in that it is not currently wrong in the docs, it just refers to WF durable reminders, which are part of the durable reminders runtime.

Copy link

github-actions bot commented Dec 7, 2023

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 7, 2023
@hhunter-ms
Copy link
Collaborator

per @msfussell comment, I'm closing this PR. we can reopen if we find it necessary!

@hhunter-ms hhunter-ms closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants