Added Crypto API reference documentation #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so it's last in list. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
WhitWaldo
force-pushed
the
crypto-reference
branch
from
c52ab61
to
aef6ff7
Compare
|
Stale PR, paging all reviewers |
…so it's last in list. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
WhitWaldo
force-pushed
the
crypto-reference
branch
from
aef6ff7
to
c3640c8
Compare
msfussell
reviewed
Jan 22, 2024
There was a problem hiding this comment.
@WhitWaldo Thanks for jumping on this. Added a few minor comments. Could you also add a link to this reference API into the Related links section on the Crypto overview here https://docs.dapr.io/developing-applications/building-blocks/cryptography/cryptography-overview/#related-links
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…ference # Conflicts: # daprdocs/content/en/reference/api/cryptography_api.md
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Done in #3952 |
msfussell
approved these changes
Jan 23, 2024
msfussell
added
P1
content/missing-information
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Provides missing Crypto API documentation following the style of the Actors and State API pages. I also updated the weight of the Error Codes reference page so it continues to show last in the reference docs list.
Issue reference
Please reference the issue this PR will close: #3945