Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Instructions to add Kubernetes Metrics server to Kind #3970

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Add Instructions to add Kubernetes Metrics server to Kind #3970

merged 1 commit into from
Jan 26, 2024

Conversation

prashantrewar
Copy link
Contributor

@prashantrewar prashantrewar commented Jan 25, 2024 •
edited
Loading

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

Fixes #3951

@prashantrewar
Add Instructions to add Kubernetes Metrics server to Kind
cda4207 
Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
@prashantrewar prashantrewar requested review from a team as code owners January 25, 2024 16:44
@prashantrewar
Copy link
Contributor Author

Don't merge this PR right now. I am updating some changes.

@msfussell msfussell modified the milestone: 1.13 Jan 26, 2024
@prashantrewar
Copy link
Contributor Author

prashantrewar commented Jan 26, 2024 •
edited
Loading

Don't merge this PR right now. I am updating some changes.

I apologize @msfussell, nothing to change anymore from my side. Could you please suggest changes if required?

yaron2
yaron2 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaron2 yaron2 merged commit 4b389d3 into dapr:v1.12 Jan 26, 2024
7 checks passed
@prashantrewar prashantrewar deleted the update-setup-kind.md branch January 26, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaron2 yaron2 yaron2 approved these changes

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instructions to add Kubernetes Metrics server to Kind
3 participants
@prashantrewar @yaron2 @msfussell