Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation (Redis state store) : Removed duplicated fields #4000

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

arthbalete
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

In Redis state store component configuration example, "failover" and "sentinelMasterName" fields were duplicated.

This commit removes these duplicates, keeping the most verbose value (eg: <bool> # Optional. Allowed: true, false instead of # Optional) and using the same position as the one in the spec metadata fields part .

Issue reference

#3999

…e in setup-redis.md

In Redis state store component configuration example (https://docs.dapr.io/reference/components-reference/supported-state-stores/setup-redis/#component-format), "failover" and "sentinelMasterName" fields were duplicated.

This commit removes these duplicates, keeping the most verbose value (eg: "<bool> # Optional. Allowed: true, false" instead of "# Optional") and using the same position as the one in the spec metadata fields part (https://docs.dapr.io/reference/components-reference/supported-state-stores/setup-redis/#spec-metadata-fields).

Signed-off-by: arthbalete <67156595+arthbalete@users.noreply.github.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution! Greatly appreciated.

@hhunter-ms hhunter-ms merged commit e76c800 into dapr:v1.12 Feb 2, 2024
7 checks passed
@yaron2 yaron2 added this to the 1.13 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants