Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add (init) --dev documentation #4023

Merged
merged 11 commits into from
Feb 14, 2024
Merged

add (init) --dev documentation #4023

merged 11 commits into from
Feb 14, 2024

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Feb 7, 2024

This made sense to link it to the existing kubernetes init documentation and add a subsection with the --dev flag documented.

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

  1. Implements dapr init -k --dev documentation in kubernetes operations
  2. Add a --dev example in the init cli reference.

Issue reference

Please reference the issue this PR will close: #3781

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!Here are a few comments.

mikeee and others added 4 commits February 9, 2024 13:58
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
@mikeee mikeee requested a review from msfussell February 9, 2024 15:51
@mikeee mikeee marked this pull request as ready for review February 9, 2024 15:51
@mikeee mikeee requested review from a team as code owners February 9, 2024 15:51
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review

mikeee and others added 2 commits February 9, 2024 18:00
Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: mikeee <hey@mike.ee>
Moved the paragraph down

Signed-off-by: Mark Fussell <markfussell@gmail.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeee
Copy link
Member Author

mikeee commented Feb 14, 2024

LGTM

@msfussell The repositioning looks good to me 👍

@hhunter-ms hhunter-ms merged commit d326c1b into dapr:v1.12 Feb 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dapr init -k --dev command needs more documentation
3 participants