Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct OTel endpointAddress argument (it's not a URL) #4067

Closed
wants to merge 314 commits into from

Conversation

andrejpk
Copy link
Contributor

@andrejpk andrejpk commented Mar 5, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

The Tracing docs imply that you should use a URL in tracing.otel.endpointAddress but it's looking for a hostname or hostname:port

Issue reference

#4068

hhunter-ms and others added 30 commits January 25, 2024 14:04
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Update limitation for js

Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
…rkflow/workflow-features-concepts.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Fixes dapr#3914

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Fixes dapr#3987

Includes documenting the new "http.increasedCardinality" configuration option

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
…ame-resolution/nr-sqlite.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Fixes dapr#3203

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
…verview.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
hhunter-ms and others added 12 commits April 25, 2024 13:40
Add section on graceful shutdown duration
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
…one with an annotation, not by setting a helm argument (dapr#4124)

Clarify that disabling kubernetes built in secret store can only be done with an annotation, not by setting a helm argument

Signed-off-by: james-bartlett <jamesmbartlett@outlook.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
[Kubernetes] Update CRD for troubleshooting step
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms removed the stale label May 7, 2024
@hhunter-ms hhunter-ms reopened this May 7, 2024
@hhunter-ms
Copy link
Collaborator

Resurrecting this PR - @andrejpk could you reopen this PR and point it to 1.13 instead of 1.12?

hhunter-ms and others added 9 commits May 7, 2024 14:38
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
…ample (dapr#4132)

* Added workflow concurrency example for .NET

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>

* Removed extension method that was doubling up calls and shortened to simpler inline example

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>

* Removed unused extension method

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>

* Neglected to include the Task.WhenAll line persisting the remaining result values

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>

* Fixed parallism limit

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>

* Adding proposed concluding thoughts

Co-authored-by: Chris Gillum <cgillum@gmail.com>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>

* Approved proposed language

Co-authored-by: Chris Gillum <cgillum@gmail.com>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>

---------

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Co-authored-by: Chris Gillum <cgillum@gmail.com>
Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Update Docker command for MongoDB state component
[Daprbot] Add rust-sdk to `/assign` support
[State stores] Add `actorStateStore` metadata to applicable specs
Copy link

Stale PR, paging all reviewers

Signed-off-by: Andrej Kyselica <andrejky@microsoft.com>
@andrejpk andrejpk closed this May 13, 2024
@andrejpk
Copy link
Contributor Author

Replaced with #4145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.