Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove memory limits in production #4091

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

alicejgibbons
Copy link
Contributor

@alicejgibbons alicejgibbons commented Mar 27, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

In Dapr 1.12+ the memory usage for the Sentry service in many production deployments of Dapr is often higher than the limits here. For all the control plane components, we should remove the memory limits entirely to avoid users hitting OOMKilled pod status errors.

Issue reference

Signed-off-by: Alice Gibbons <alice@diagrid.io>
@alicejgibbons alicejgibbons requested review from a team as code owners March 27, 2024 11:41
@alicejgibbons
Copy link
Contributor Author

@msfussell cc: @JoshVanL

@yaron2 yaron2 merged commit f1d1124 into dapr:v1.13 Mar 27, 2024
7 checks passed
@alicejgibbons alicejgibbons deleted the alicejgibbons/remove-mem-limits branch March 27, 2024 12:32
@alicejgibbons alicejgibbons restored the alicejgibbons/remove-mem-limits branch March 27, 2024 12:33
@alicejgibbons alicejgibbons deleted the alicejgibbons/remove-mem-limits branch March 27, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants